Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Fix hijack ordering which broke websockets #5679

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

WeidiDeng
Copy link
Member

@WeidiDeng WeidiDeng commented Aug 3, 2023

Fix #5678

@francislavoie francislavoie changed the title fix hijack in reverse proxy reverseproxy: Fix hijack ordering which broke websockets Aug 3, 2023
@francislavoie francislavoie added the bug 🐞 Something isn't working label Aug 3, 2023
@francislavoie francislavoie added this to the v2.7.2 milestone Aug 3, 2023
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry 🙈

@francislavoie francislavoie enabled auto-merge (squash) August 3, 2023 04:00
@francislavoie francislavoie merged commit e2fc08b into master Aug 3, 2023
19 checks passed
@francislavoie francislavoie deleted the fix-hijack-reverse-proxy branch August 3, 2023 04:08
@mholt
Copy link
Member

mholt commented Aug 3, 2023

Thank you for the patch. And I'm sorry for merging the other PR when I did -- even though it was said, I just didn't realize how much more testing was still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.7.1: websockets randomly work or don't
3 participants