Fix string does not match ~[]E error

[hslatman]

Fixes #5674

[CLAassistant]

All committers have signed the CLA.

[mholt]

What is this exactly? I do not get this error, nor does our CI, and builds succeeded.

[hslatman]

Yea, I was kind of surprised myself too.

I hit this error when building Caddy with one of my modules. Another person seems to have hit the same issue with a custom module: #5673

[mholt]

Huh. Alrighty then.

LGTM. I'm not sure why we need the exp package here anyway. Thanks

[francislavoie]

Does the import need updating? (Run gofmt)

Oh nvm we still use Compact

[hslatman]

Does the import need updating? (Run go mod tidy)

Doesn't look like it. Still one slices usage.

[mholt]

Weird that only this occurrence needs changing then.

As I do not get this error, nor does our CI, I'm trusting you on this 😊

[hslatman]

Here's a reproducer on the playground: https://go.dev/play/p/NsaynrOjz9i

[mholt]

Is that using the same commit of x/exp that is in our go.mod? (Sorry, I would check myself, but I'm traveling/mobile and scrambling to get my laptop set up to tag a signed release.)

[francislavoie]

Oh, I guess it needs to be slices.Sort[[]string](s) i.e. with the []. Still don't understand why it didn't fail for us before though.

[hslatman]

Oh, I guess it needs to be slices.Sort[[]string](s) i.e. with the []. Still don't understand why it didn't fail for us before though.

That does compile on the playground 🙂

[mholt]

If the playground always uses the latest commits, ours is not using the latest commit of x/exp. That might be the difference, somehow?

[hslatman]

Maybe this commit is related: golang/go@0a48e5c