Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode: Fix infinite recursion #5672

Merged
merged 1 commit into from
Aug 3, 2023
Merged

encode: Fix infinite recursion #5672

merged 1 commit into from
Aug 3, 2023

Conversation

francislavoie
Copy link
Member

Fix #5671

@francislavoie francislavoie added the bug 🐞 Something isn't working label Aug 2, 2023
@francislavoie francislavoie mentioned this pull request Aug 2, 2023
Closed
@francislavoie francislavoie added this to the v2.7.1 milestone Aug 2, 2023
mholt
mholt approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investigating and quickly posting a patch. LGTM. Anywhere else this might be needed that you can think of?

(I'd look, but am visiting family and just a bit busy.)

@mholt mholt merged commit 1913930 into master Aug 3, 2023
19 checks passed
@mholt mholt deleted the fix-infinite-recursion branch August 3, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

@JeDaYoshi JeDaYoshi JeDaYoshi approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging this pull request may close these issues.

Infinite loop on goroutine with http.ResponseController changes
3 participants
@francislavoie @mholt @JeDaYoshi