modules: pre-commit: make pkgs.buildEnv composable #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a git-hooks.lib.<SYSTEM>.run derivation as a path to
pkgs.buildEnv results in the following error due to derivations with an
empty file being treated differently from derivations with an empty
directory:
The store path <TARGET> is a file and can't be merged into an
environment using pkgs.buildEnv!
Since Nixpkgs rejected explicitly handling derivations with an empty
file in pkgs.buildEnv [1], affected derivations should transition from
'touch $out' to 'mkdir $out' to be pkgs.buildEnv composable.
This change replaces 'touch $out' with 'mkdir $out' and makes the
following command work:
nix \
build \
--expr '
let
flake = builtins.getFlake (toString ./.);
system = builtins.currentSystem;
in
flake.inputs.nixpkgs.legacyPackages.${system}.buildEnv {
name = "";
paths = [(flake.outputs.lib.${system}.run {src = ./.;})];
}
' \
--impure
[1]: NixOS/nixpkgs#325140
Link: cachix#498
trueNAHO
force-pushed
the
modules-pre-commit-run-make-pkgs-buildenv-composable
branch
from
cfb75e0 to
9f73309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 9f73309ff19bda94d6bcbe77dcd72c1c65a9f37d [...] modules: pre-commit: make pkgs.buildEnv composable Passing a git-hooks.lib.<SYSTEM>.run derivation as a path to pkgs.buildEnv results in the following error due to derivations with an empty file being treated differently from derivations with an empty directory: The store path <TARGET> is a file and can't be merged into an environment using pkgs.buildEnv! Since Nixpkgs rejected explicitly handling derivations with an empty file in pkgs.buildEnv [1], affected derivations should transition from 'touch $out' to 'mkdir $out' to be pkgs.buildEnv composable. This change replaces 'touch $out' with 'mkdir $out' and makes the following command work: nix \ build \ --expr ' let flake = builtins.getFlake (toString ./.); system = builtins.currentSystem; in flake.inputs.nixpkgs.legacyPackages.${system}.buildEnv { name = ""; paths = [(flake.outputs.lib.${system}.run {src = ./.;})]; } ' \ --impure [1]: https://github.com/NixOS/nixpkgs/pull/325140 Link: https://github.com/cachix/git-hooks.nix/pull/498For example, this PR allows me to include the
git-hookscheck inpkgs.buildEnv: https://github.com/trueNAHO/dotfiles/blob/4fdeb9e4e6bf6cb2255b89f5d75aab167d3bdde7/flake.nix#L707-L751