Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: rename and alias to git-hooks #1571

Merged
merged 7 commits into from
Nov 9, 2024
Merged

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Nov 3, 2024

Renames every mention of pre-commit-hooks to git-hooks.

For backwards-compatibility
  • pre-commit is aliased to git-hooks, without throwing a deprecation warning to reduce churn.
  • pre-commit-hooks input follows the git-hooks input.
  • Probably unnecessary, but the git-hooks module will try both inputs before failing.
Removed

I removed pre-commit-hooks from specialArgs. It was only used by our module and I doubt anyone relied on it. We use inputs.<name> instead.

@sandydoo sandydoo added the enhancement New feature or request label Nov 3, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2024

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 934e851
Status: ✅  Deploy successful!
Preview URL: https://aea1669a.devenv.pages.dev
Branch Preview URL: https://alias-pre-commit.devenv.pages.dev

View logs

@sandydoo sandydoo marked this pull request as ready for review November 4, 2024 12:26
@sandydoo
Copy link
Member Author

sandydoo commented Nov 4, 2024

git-hooks.hooks is a little annoying to read, but we can't really do git.hooks because of all the other top-level git-hooks options, like settings, excludes, etc.

@sandydoo sandydoo requested a review from domenkozar November 8, 2024 21:45
@domenkozar domenkozar merged commit 9831533 into main Nov 9, 2024
261 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants