Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency improvements #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergzin
Copy link
Contributor

@sergzin sergzin commented Apr 26, 2024

Introducing the run_as_async function to enhance concurrency by enabling the execution of loop-blocking code in a separate thread. Additionally, localizing the dis_client variable within a function scope to prevent potential data races.

…king code in a separate thread. dis_client is moved to local function scope to prevent data races.
@craigpratt
Copy link
Member

I think we should consider making this async as part of an effort to remove the dependency on quart.

Quart was a transition technology prior to other libraries/frameworks implementing async request processing. But it's now holding back updates to some of the dependent packages.

I propose 2 criteria for the package to use in place of Quart:

  1. The new request package doesn't require the use of an WSGI/ASGI (a web frontend) - as the DIS client doesn't need to horizontally scale.
  2. We use packages from the Python standard library.

Now something like FastAPI might be overkill - and think goes counter to (2) - but wouldn't want to rule it out. But something like Django is definitely "out" IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants