Always use the renderViewEntity for relative coordinates #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntity Also added a new helper method to IPlayerContext to retrieve the view position and change existing uses of the view position to use the new method.
|
For many of these yeah, but I'm not sure about all. The point of |
|
I made this to make the behaviour of relative coordinates consistent, but if you want I can revert it for things like I also thought about letting the user decide by adding another type of coordinate, but I'm not really a fan of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also thought about doing it for a few other things that happen relative to the player like
#tunnelor#thiswayand decided against it, keeping an explicit distinction rather than "here it makes sense to do it relative to the camera but not there".