Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mixin dependency to newest version #2622

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wagyourtail
Copy link
Collaborator

update mixin version to 0.8.3

@leijurv
Copy link
Member

leijurv commented Mar 29, 2021

we tried this before, a very long time ago. i truly cannot remember what went wrong, but a lot did

@leijurv leijurv requested a review from ZeroMemes March 29, 2021 06:04
@wagyourtail
Copy link
Collaborator Author

might need another commit, there's an issue with ow2.asm not having the right version so java.lang.ClassNotFoundException: org.objectweb.asm.commons.ClassRemapper

on a slightly unrelated note I also seem to not be able to build for forge btw, even before these changes. doing -Pbaritone.forge_build is still giving me notch mappings.

@wagyourtail wagyourtail marked this pull request as draft March 29, 2021 07:13
@scorbett123
Copy link
Collaborator

Does this not break compatibility with like, every other mod where baritone is built in? Such as impact etc.

@5HT2
Copy link
Contributor

5HT2 commented Mar 29, 2021

yeah I posted a crash log on dependency bot's pull

@wagyourtail
Copy link
Collaborator Author

wagyourtail commented Mar 29, 2021

the main reason for this is because forge is stupid and if multiple different versions of mixins are shaded and the newer one isnt loaded first (ie with replaymod which is why adding ! To front works on forge) it crashes. Also sponge says to update to 8,
Might need to move main branch to FG3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants