Go Home After Mining and check Ineventory whileMining #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/api/java/baritone/api/utils/ExampleBaritoneControl.java # src/main/java/baritone/process/MineProcess.java
…king inventory to mining and farming processes.
DRY out the inventory management code.
Conform to code review, remove redundant if statement.
|
Good addition! |
CDAGaming
suggested changes
Aug 18, 2020
leijurv
requested changes
Oct 14, 2020
|
I think most of my code is outdated and I will rework it in the next days |
# Conflicts: # src/main/java/baritone/command/defaults/DefaultCommands.java # src/main/java/baritone/process/MineProcess.java
|
My guy, just use intellij's autoformat instead of manually fixing everything. Ctrl alt O + Ctrl alt L |
|
Yeah I know, sadly I didn't use it when I created this PR 1 year ago. BTW autoformat didn't remove all blank lines. |
CDAGaming
suggested changes
Oct 17, 2020
| for(BlockOptionalMeta bom : filter.blocks()) { | ||
| Block block = bom.getBlock(); | ||
| Item item = block.getItemDropped(block.getDefaultState(), new Random(), 0); | ||
| Item ore = Item.getItemFromBlock(block); |
There was a problem hiding this comment.
Isn't there a method in block like block.asItem...
I know there is in newer mc versions, as getItemFromBlock does become deprecated
There was a problem hiding this comment.
I didn't found the method in this mc version.
There was a problem hiding this comment.
Ah, alright. I'll leave this comment though for the Baritone maintainers to use asItem for up-porting this
CDAGaming
approved these changes
Oct 17, 2020
|
just realized this solves #605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated pull request #910 to baritone 1.2.10 . see pull request #910 for further information