Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialise transactionTemplate if needed #55

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Initialise transactionTemplate if needed #55

merged 1 commit into from
Jul 22, 2024

Conversation

forus
Copy link
Contributor

@forus forus commented Jul 19, 2024

JdbcUtil.getTransactionTemplate() returned null causing null pointer exception for all commands that used transaction programatically:

  • RemoveSamples
  • RemovePatients
  • ImportCnaDiscreteLongData
  • ImportTabDelimData

@forus
Initialise transactionTemplate if needed
d6e1473 
JdbcUtil.getTransactionTemplate() returns
null causing null pointer exception.
@forus forus added the bug Something isn't working label Jul 19, 2024
pieterlukasse
pieterlukasse reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to include a test covering getTransactionTemplate in this case. Apparently the existing set of tests were not sufficient for catching this in CI 🤔

@forus
Copy link
Contributor Author

forus commented Jul 22, 2024

I think it would be good to include a test covering getTransactionTemplate in this case. Apparently the existing set of tests were not sufficient for catching this in CI 🤔

@pieterlukasse this case is covered by tests in cbiportal #36

@forus forus merged commit 3bef9a1 into main Jul 22, 2024
4 checks passed
@forus forus deleted the fix_tx_template_npe branch July 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheridancbio sheridancbio sheridancbio approved these changes

@pieterlukasse pieterlukasse pieterlukasse approved these changes

Assignees

@pieterlukasse pieterlukasse

@sheridancbio sheridancbio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forus @pieterlukasse @sheridancbio