Remove unused code from DaoSampleList.addSampleList()

cBioPortal · Jun 21, 2024 · 5a44709 · 5a44709
1 parent 96acec5
commit 5a44709
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/main/java/org/mskcc/cbio/portal/dao/DaoSampleList.java b/src/main/java/org/mskcc/cbio/portal/dao/DaoSampleList.java
@@ -50,7 +50,6 @@ public class DaoSampleList {
     public int addSampleList(SampleList sampleList) throws DaoException {
         Connection con = null;
         PreparedStatement pstmt = null;
-        ResultSet rs = null;
         int rows;
         try {
             con = JdbcUtil.getDbConnection(DaoSampleList.class);
@@ -66,16 +65,15 @@ public int addSampleList(SampleList sampleList) throws DaoException {
             try (ResultSet generatedKey = pstmt.getGeneratedKeys()) {
                 if (generatedKey.next()) {
                     int listId = generatedKey.getInt(1);
-                    int listListRow = addSampleListList(sampleList.getCancerStudyId(), listId, sampleList.getSampleList(), con);
-                    rows = (listListRow != -1) ? (rows + listListRow) : rows;
+                    rows += addSampleListList(sampleList.getCancerStudyId(), listId, sampleList.getSampleList(), con);
                 } else {
                     throw new DaoException("Creating sample list failed, no ID obtained.");
                 }
             }
         } catch (SQLException e) {
             throw new DaoException(e);
         } finally {
-            JdbcUtil.closeAll(DaoSampleList.class, con, pstmt, rs);
+            JdbcUtil.closeAll(DaoSampleList.class, con, pstmt, null);
         }
 
         return rows;