-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(appengine): Persistent volumes .persistentVolumeReclaimPolicy n… #209
base: develop
Are you sure you want to change the base?
Conversation
I'm curious about the use-case behind this change. I assume this is coming from snapshot/volume management requirements, but is this something specific to AppEngine, or do we want this retention policy to be the default for ALL applications and their volumes? If it's for all applications, could it be better to manage this: |
Good feedback @conneryn. @robblovell will likely be the best person to respond. |
Hey Connery, Currently, when a volume is detached, the volume management system sets the volume to 'retain' as part of the process. At one point I had thought that it would assume it was 'retain', but decided after Grant's implementation to default the value to 'retain' to do this. So volume management no longer needs the value to be 'retain'. However, I think it would be surprising to any app developer if they installed an app and detached the volume that the volume data would disappear. During development, that might be desirable, but during normal operation, I would expect databases and storage volumes to be retained unless explicitly deleted. Because of this, I think we should keep logic to set volumes to 'retain' for all applications regardless of whether the storage policy for the cloud is something else like 'delete'. |
I think this should be just an App Engine feature for now. |
Co-authored-by: Narayan Sainaney <[email protected]>
Co-authored-by: Narayan Sainaney <[email protected]>
…ow set to Retain
Description
Persistent volumes .persistentVolumeReclaimPolicy now set to Retain, by default.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Optional:
Checklist: