Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags functionality implemented #108

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Aditya-Sakpal
Copy link

Description

In this pr I have implemented the add tags functionality . Now while creating the tutorial the creator can add tags according to their tutorial . Also I have displayed them in the Card.

Motivation and Context

Adding tags functionality was unimplemented

Test Results

image

Video Reference

add_tags_functionality.webm

Types of changes

  • ❎ Bug fix (non-breaking change which fixes an issue)
  • ✅ New feature (non-breaking change which adds functionality)
  • ❎ Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • ✅ My code follows the code style of this project.
  • ❎ My change requires a change to the documentation.
  • ✅ All new and existing tests passed.

Request to review

@Maahi10001 @ABHISHEK-PANDEY2 @Shiva-Nanda @shivareddy6 please review my pull request

@rohitPandey469
Copy link

@Aditya-Sakpal Hey brother, How about adding an option to edit the already selected tags ( tags selected at the time of tutorial ) while writing tutorial content, that would be more cool right - like the user will be having more command over tutorial tags. What do you think????
If you want to know about its implementation then check scorelab/Codelabz#1210
Something similar or actually the same thing is done here :)

@Aditya-Sakpal
Copy link
Author

@rohitPandey469 great idea bro , but rather than providing them predefined tags we should allow them to add their own tags . Like we can add up your's pr and my pr and create something even more useful . What do you think ?

@rohitPandey469
Copy link

Cool @Aditya-Sakpal let @ABHISHEK-PANDEY2 Sir know about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants