feat: #3697 add waypoints external resources section #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2024
brunobesson
approved these changes
Feb 20, 2024
|
API has been updated in production. We should test and merge if ok. |
|
I thus tested this PR, and it is working fine 👏 However, we should have a specific placeholder, different from that for routes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3697
Associated backend PR: c2corg/v6_api#1747
How to test:
Pull the associated backend branch
feature/add-waypoints-external-resourcesRun the added migration using docker-compose exec api .build/venv/bin/alembic upgrade head
Create a new waypoint and fill the
external_resourcesfield. Then update the external resources of this.You should see something like this: