Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff config, pytest config, pre-commit config #210

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Dec 12, 2024

Blocked by #209. Once its merged I'll rebase this onto it and run the tooling. 64ec4af and after are the commits that are part of this PR

Added:

  • Ruff config
  • pre-commit config
  • pytest config

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just the ruff changes? The ruff changes should be merged before #209. This pr should only include formatting changes and no tooling changes or doc reorgs or new material.

@VeckoTheGecko
Copy link
Contributor Author

The ruff changes should be merged before #209

ok, I can rebase

@VeckoTheGecko
Copy link
Contributor Author

Good to go @jklymak . I also added a .git-blame-ignore-revs file so that the changes don't show up in git blame (as they're all just formatting changes).

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 62.69841% with 94 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (7ec1b8e) to head (ac3f2c5).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pyglider/slocum.py 23.18% 53 Missing ⚠️
pyglider/utils.py 66.03% 18 Missing ⚠️
pyglider/ncprocess.py 43.47% 13 Missing ⚠️
pyglider/seaexplorer.py 81.25% 9 Missing ⚠️
tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   55.11%   54.90%   -0.22%     
==========================================
  Files           9        9              
  Lines        1700     1692       -8     
==========================================
- Hits          937      929       -8     
  Misses        763      763              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jklymak jklymak merged commit 60ea41b into c-proof:main Dec 16, 2024
7 checks passed
@VeckoTheGecko VeckoTheGecko deleted the changes2 branch December 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants