Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not block in accept #73

Closed
wants to merge 1 commit into from
Closed

Conversation

c-cube
Copy link
Owner

@c-cube c-cube commented Dec 4, 2023

cc @vphantom ?

@vphantom
Copy link
Contributor

vphantom commented Dec 4, 2023

You no longer enforce a maximum number of concurrent connections?

@vphantom
Copy link
Contributor

vphantom commented Dec 4, 2023

Sorry sorry, I was just looking at the diff lines. I guess you're changing your multi-threading strategy if you're going from blocking to non-blocking there. I don't really know what I should be evaluating here.

@c-cube
Copy link
Owner Author

c-cube commented Dec 4, 2023 via email

@vphantom
Copy link
Contributor

vphantom commented Dec 4, 2023

Oh! I forgot that the graceful shutdown was still an issue. (I've been neck-deep in unrelated work for so long…) For sure stopping the accept loop as soon as the signal is received, and not after the next client is accepted, is a much more predictable behavior.

@c-cube c-cube closed this Dec 5, 2023
@c-cube c-cube deleted the wip-graceful-shutdown-accept branch December 5, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants