Additional Algorithms #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of missing algorithms. completed algorithms are AF, ASR, and RAAR
Completed all missing algorithms. There is no direct use of R_m or R_s operators from Bcdi core. If these algorithms would run more efficiently with the use of the more direct reflector operations it will be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jason,
Here is my work so far on the additional algorithms. I hope this is not too far off base from what will work and that it can be molded to fit your style in the other code. I was unable to find the bcdi core and therefore didn't apply the R_s and R_m operations directly to state.realSpace. Keep me in the loop on anything that needs adjustment and I will get it done as soon as possible