Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OPRF #49

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Update OPRF #49

merged 6 commits into from
Feb 8, 2023

Conversation

bytemare
Copy link
Owner

Update to changes in cfrg/draft-irtf-cfrg-voprf#371

Signed-off-by: bytemare [email protected]

@bytemare
Copy link
Owner Author

Waiting for vector updates for OPRF changes in https://github.com/cfrg/draft-irtf-cfrg-opaque

@gitguardian
Copy link

gitguardian bot commented Feb 8, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4598333 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
4598333 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
4598335 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
4598335 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
5708160 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
5708160 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
5708161 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
5708161 Generic High Entropy Secret 1f6fea8 tests/vectors.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #49 (ded90dd) into main (d51f93e) will decrease coverage by 0.31%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   98.63%   98.33%   -0.31%     
==========================================
  Files          23       21       -2     
  Lines         659      719      +60     
==========================================
+ Hits          650      707      +57     
- Misses          5        6       +1     
- Partials        4        6       +2     
Impacted Files Coverage Δ
internal/configuration.go 50.00% <ø> (-30.00%) ⬇️
internal/encoding/misc.go 100.00% <ø> (ø)
internal/hash.go 100.00% <ø> (ø)
internal/oprf/oprf.go 80.48% <78.12%> (-11.52%) ⬇️
client.go 100.00% <100.00%> (ø)
deserializer.go 100.00% <100.00%> (ø)
internal/ake/3dh.go 100.00% <100.00%> (ø)
internal/ake/client.go 100.00% <100.00%> (ø)
internal/ake/server.go 100.00% <100.00%> (ø)
internal/encoding/encoding.go 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@bytemare bytemare merged commit 7dd75ce into main Feb 8, 2023
@bytemare bytemare deleted the update-oprf branch February 8, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant