-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace legacy impl with Poll #329
base: master
Are you sure you want to change the base?
Conversation
ff53fe4
to
8189e24
Compare
Thank you very much! Please allow me some time to review it! |
Could you re-push it and trigger the CI? |
You can also saw CI results in https://github.com/loongs-zhang/monoio/commits/dev-refactor-poll |
I think the CI fails due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good change which I wanted long time before(#269).
The only thing I concern is the legacy feature. I think it cannot be treated as poll-io
, which is a supplement to polling ability under iouring.
And another unrelated issue I think about when reading my old PR draft, the latest monoio-macro's test macro seems not work in user code due to some
Maybe we can come about a way to fix and do it in another PR. |
1d38188
to
2e26222
Compare
4c6f450
to
0849775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great! Could you by the way fix the clippy warnings to pass CI?
This will bump the MSRV to 1.74, but since 1.74 was published at Nov. 2023, I think it is fine.
https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
5da9ceb
to
aaa0422
Compare
Done, but the loongarch64-unknown-linux-gnu nightly fails, track on cross-rs/cross#1640 |
No description provided.