Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define monoio MSRV to 1.80 #282

Closed

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Aug 2, 2024

This PR marks monoio available in stable rust.

We deprecated the unstable feature because most of the functionalities we need are now stable or have alternatives. Developing Monoio on stable Rust will allow a broader ecosystem to explore and use Monoio. This change will also reduce the burden on our maintainers.

@Xuanwo Xuanwo requested a review from ihciah August 2, 2024 09:15
@ihciah
Copy link
Member

ihciah commented Aug 7, 2024

It is available in stable version right now I think...

It requires nightly only if unstable feature is enabled. Keep this feature allows us to do some cool things based on nightly features while still does not affect stable users.

I tend to keep this feature.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Aug 7, 2024

I tend to keep this feature.

That's fine to me. I can keep unstable.

We can revisit the MSRV topic in the future. Let's close this PR now.

@Xuanwo Xuanwo closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants