Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g3-icap-client: decode http body if content-length is known #391

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

zh-jq-b
Copy link
Member

@zh-jq-b zh-jq-b commented Nov 26, 2024

close #390

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 57.70115% with 184 lines in your changes missing coverage. Please review.

Project coverage is 50.75%. Comparing base (ff4b6a6) to head (be844c0).

Files with missing lines Patch % Lines
lib/g3-icap-client/src/reqmod/h1/bidirectional.rs 0.00% 50 Missing ⚠️
lib/g3-http/src/client/transparent.rs 43.13% 29 Missing ⚠️
lib/g3-http/src/client/response.rs 42.55% 27 Missing ⚠️
lib/g3-icap-client/src/respmod/h1/recv_response.rs 56.86% 22 Missing ⚠️
lib/g3-icap-client/src/respmod/h1/bidirectional.rs 63.63% 20 Missing ⚠️
lib/g3-icap-client/src/reqmod/h1/recv_request.rs 72.72% 15 Missing ⚠️
lib/g3-http/src/server/request.rs 81.63% 9 Missing ⚠️
lib/g3-http/src/server/transparent.rs 83.01% 9 Missing ⚠️
lib/g3-icap-client/src/reqmod/h1/forward_body.rs 0.00% 1 Missing ⚠️
lib/g3-icap-client/src/reqmod/h1/preview.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   50.73%   50.75%   +0.02%     
==========================================
  Files        1091     1091              
  Lines       99530    99767     +237     
==========================================
+ Hits        50498    50640     +142     
- Misses      49032    49127      +95     
Flag Coverage Δ
g3proxy 50.76% <57.70%> (+0.02%) ⬆️
lib 25.28% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zh-jq-b zh-jq-b force-pushed the icap-encoding branch 2 times, most recently from b3fddc5 to f3e9ecd Compare November 26, 2024 08:19
@zh-jq-b zh-jq-b marked this pull request as ready for review November 26, 2024 08:34
@zh-jq-b zh-jq-b merged commit 608e799 into master Nov 26, 2024
97 checks passed
@zh-jq-b zh-jq-b deleted the icap-encoding branch November 26, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICAP egress traffic hardcodes transfer-encoding chunked
3 participants