rust: Store raw intrinsics in vtables #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating a wrapper-per-intrinsic try to instead store raw functions inside of vtables to push as much code as possible into `mod async_support`, as it's generally easier to grok code in one location rather than generated code. Note that this does not update the `read` or `write` vtable functions as they're going to be trickier, if even possible, to expose the more raw version. This shouldn't have any functional change, it's just a reorganizing. The `cancel_*` intrinsics are all marked with a `TODO`, however, to come back and reconsider the return value which is otherwise discarded right now.
dicej
approved these changes
Mar 3, 2025
| @@ -84,7 +103,11 @@ impl<T> CancelableWrite<T> { | |||
| Handle::LocalReady(..) => { | |||
| entry.insert(Handle::LocalOpen); | |||
| } | |||
| Handle::Write => (writer.vtable.cancel_write)(writer.handle), | |||
| Handle::Write => unsafe { | |||
| // TODO: spec-wise this can return `BLOCKED` which seems | |||
There was a problem hiding this comment.
It can only return BLOCKED if called with the async option enabled. As long as we don't try to import it using the [async] prefix, we should be good.
There was a problem hiding this comment.
Ah ok, I'll leave this as a follow-up of #1188 to come back and fill in comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating a wrapper-per-intrinsic try to instead store raw functions inside of vtables to push as much code as possible into
mod async_support, as it's generally easier to grok code in one location rather than generated code.Note that this does not update the
readorwritevtable functions as they're going to be trickier, if even possible, to expose the more raw version.This shouldn't have any functional change, it's just a reorganizing. The
cancel_*intrinsics are all marked with aTODO, however, to come back and reconsider the return value which is otherwise discarded right now.