Skip to content

Use Waker::noop from Rust 1.85 #10804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Use Waker::noop from Rust 1.85 #10804

merged 1 commit into from
May 22, 2025

Conversation

alexcrichton
Copy link
Member

Now possible after #10785

@alexcrichton alexcrichton requested review from a team as code owners May 19, 2025 14:02
@alexcrichton alexcrichton requested review from dicej and removed request for a team May 19, 2025 14:02
@github-actions github-actions bot added fuzzing Issues related to our fuzzing infrastructure wasi Issues pertaining to WASI wasmtime:c-api Issues pertaining to the C API. labels May 19, 2025
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing", "wasi", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton requested a review from cfallin May 22, 2025 16:17
cfallin
cfallin approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner without the manual implementations -- thanks!

@cfallin cfallin added this pull request to the merge queue May 22, 2025
Merged via the queue into bytecodealliance:main with commit d41b0a7 May 22, 2025
43 checks passed
@alexcrichton alexcrichton deleted the use-waker-noop branch May 22, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

@dicej dicej Awaiting requested review from dicej dicej is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
fuzzing Issues related to our fuzzing infrastructure wasi Issues pertaining to WASI wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @cfallin