Duplicate page size determination in wasmtime-fiber
#10803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Wasmtime has a function
crate::runtime::vm::host_page_size
but this isn't reachable from the
wasmtime-fiber
crate and instead thacrate uses
rustix::param::page_size
to determine the host page size.It looks like this usage of
rustix
is causing a panic in #10802.Ideally
wasmtime-fiber
would be able to use the same function but thecrate separation does not currently make that feasible. For now
duplicate the logic of
wasmtime
intowasmtime-fiber
as it's modestenough to ensure that this does not panic.
Closes #10802