Implement select.
#1162
Merged
Implement select.
#1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `select` function, defined only on platforms where it doesn't have an `FD_SETSIZE` limitation.
sunfishcode
force-pushed
the
sunfishcode/select
branch
from
896036c
to
fff5c2a
Compare
In the `waitpid` tests, ensure that the child process has exited, as dropping `Command` otherwise leaves the process running. This fixes test hangs on macos.
sunfishcode
force-pushed
the
sunfishcode/select
branch
from
63acdd8
to
dd44e09
Compare
And make `select` unsafe due to I/O safety.
notgull
reviewed
Sep 15, 2024
Comment on lines
+21
to
+23
| readfds: Option<&mut [FdSetElement]>, | ||
| writefds: Option<&mut [FdSetElement]>, | ||
| exceptfds: Option<&mut [FdSetElement]>, |
There was a problem hiding this comment.
Is this tested on Win32? It looks like it has a slightly different implementation of FD_SET than Unix does, that isn't implemented in the bitfield way.
There was a problem hiding this comment.
Ooh, good spot. I had not yet tested it on Windows. I'll just disable Windows support for now.
There was a problem hiding this comment.
I'm worried that the current way it's implemented would make Windows support impossible in the future without a breaking change.
There was a problem hiding this comment.
Yes. I was thinking of just skipping the Windows tax here until someone shows up with a use case that needs it. If that happens, we could do like a select_ng or whatever until the next semver break.
There was a problem hiding this comment.
I changed my mind here, and decided to re-introduce Windows support, partly because WASI also uses a count+array fd_set like Windows does, and partly because I thought of a way to support this that doesn't radically change the public API.
Windows has a different `FD_SET` representation. Supporting it might be possible, though the documentation is ambiguous about whether it supports arbitrary `FD_SETSIZE` values. But even if so, it would require a more elaborate abstraction, so just drop it for now.
This uses a trick where we still allow users to allocate a `FdSetElement` array, but we just allocate a `FD_SET` on Windows out of it.
sunfishcode
force-pushed
the
sunfishcode/select
branch
from
9416878
to
06bc6e7
Compare
sunfishcode
force-pushed
the
sunfishcode/select
branch
from
9907250
to
7b27712
Compare
sunfishcode
force-pushed
the
sunfishcode/select
branch
from
7b27712
to
f321b9a
Compare
sunfishcode
added a commit
that referenced
this pull request
Oct 17, 2024
* Implement `select`. Add a `select` function, defined only on platforms where it doesn't have an `FD_SETSIZE` limitation. * Fix test hangs on macos. In the `waitpid` tests, ensure that the child process has exited, as dropping `Command` otherwise leaves the process running. This fixes test hangs on macos. * Wait for the child process after signaling it. * Fix the vector sizes in the test. * Add `fd_set` and other convenience functions. * Switch to a safe API. * Support `select` on Linux and Windows too. This uses a trick where we still allow users to allocate a `FdSetElement` array, but we just allocate a `FD_SET` on Windows out of it. And make `select` unsafe due to I/O safety. * Fix qemu to implment arbitrary-sized fd sets for `select`. * Support WASI. * Ignore "unstable name collisions" warnings for now.
sunfishcode
added a commit
that referenced
this pull request
Oct 17, 2024
* Implement `select`. Add a `select` function, defined only on platforms where it doesn't have an `FD_SETSIZE` limitation. * Fix test hangs on macos. In the `waitpid` tests, ensure that the child process has exited, as dropping `Command` otherwise leaves the process running. This fixes test hangs on macos. * Wait for the child process after signaling it. * Fix the vector sizes in the test. * Add `fd_set` and other convenience functions. * Switch to a safe API. * Support `select` on Linux and Windows too. This uses a trick where we still allow users to allocate a `FdSetElement` array, but we just allocate a `FD_SET` on Windows out of it. And make `select` unsafe due to I/O safety. * Fix qemu to implment arbitrary-sized fd sets for `select`. * Support WASI. * Ignore "unstable name collisions" warnings for now.
sunfishcode
added a commit
that referenced
this pull request
Oct 20, 2024
* Implement `select`. Add a `select` function, defined only on platforms where it doesn't have an `FD_SETSIZE` limitation. * Fix test hangs on macos. In the `waitpid` tests, ensure that the child process has exited, as dropping `Command` otherwise leaves the process running. This fixes test hangs on macos. * Wait for the child process after signaling it. * Fix the vector sizes in the test. * Add `fd_set` and other convenience functions. * Switch to a safe API. * Support `select` on Linux and Windows too. This uses a trick where we still allow users to allocate a `FdSetElement` array, but we just allocate a `FD_SET` on Windows out of it. And make `select` unsafe due to I/O safety. * Fix qemu to implment arbitrary-sized fd sets for `select`. * Support WASI. * Ignore "unstable name collisions" warnings for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
selectfunction, defined only on platforms where it doesn't have anFD_SETSIZElimitation.