Skip to content

Use the AmbientAuthority type instead of unsafe to indicate ambient authority #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2021
Merged

Use the AmbientAuthority type instead of unsafe to indicate ambient authority #166

merged 2 commits into from
May 26, 2021

Conversation

sunfishcode
Copy link
Member

@sunfishcode sunfishcode commented Apr 14, 2021 •
edited
Loading

Use the ambient-authority crate instead of unsafe.

Use the newly-created ambient-authority crate to indicate functions
which have ambient authority, rather than using unsafe.

Fixes #141.

@sunfishcode sunfishcode force-pushed the sunfishcode/ambient-authority branch 7 times, most recently from a15b761 to fe96171 Compare April 14, 2021 23:32
@sunfishcode
Copy link
Member Author

This works reasonably well, and does eliminate the last unsafe code from cap-primitives, which is nice. I want to do some experimenting with this from a user perspective before committing to it though.

@sunfishcode sunfishcode mentioned this pull request Apr 15, 2021
Closed
@sunfishcode sunfishcode force-pushed the sunfishcode/ambient-authority branch from fe96171 to 19e713c Compare May 12, 2021 22:15
@sunfishcode
Use the ambient-authority crate instead of unsafe.
d959bcf 
Use the newly-created ambient-authority crate to indicate functions
which have ambient authority, rather than using `unsafe`.

Fixes #141.
@sunfishcode sunfishcode force-pushed the sunfishcode/ambient-authority branch from 19e713c to a48ce8e Compare May 24, 2021 22:26
@sunfishcode sunfishcode force-pushed the sunfishcode/ambient-authority branch from a48ce8e to f7cd22b Compare May 24, 2021 23:11
@sunfishcode sunfishcode merged commit 1ec2258 into main May 26, 2021
@sunfishcode sunfishcode deleted the sunfishcode/ambient-authority branch May 26, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is unsafe the best way to indicate ambient authority?
1 participant
@sunfishcode