Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unneeded modules #605

Merged
merged 36 commits into from
Nov 19, 2024
Merged

Conversation

akotlar
Copy link
Collaborator

@akotlar akotlar commented Nov 19, 2024

  • Cleanup unneeded modules

Summary by CodeRabbit

  • Chores
    • Removed multiple GitHub Actions workflows related to building, testing, and installing Perl applications.
    • Deleted various configuration and documentation files, including installation guides and changelogs.
    • Removed several Perl modules and packages related to genomic data processing and annotations.
    • Eliminated scripts for managing database interactions and file handling.
    • Cleaned up unused or redundant files and directories across the project.

akotlar added 29 commits April 5, 2024 19:57
@akotlar akotlar requested a review from cristinaetrv November 19, 2024 19:57
Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the deletion of multiple files related to the Bystro Annotator project, including GitHub Actions workflows for building, testing, and installing the application, as well as various Perl scripts and configuration files. The removed files encompassed workflows for Docker builds, code quality checks, package builds, and installation scripts, along with documentation files and Perl modules that handled genomic data processing. The overall change signifies a significant reduction in the project's complexity and functionality.

Changes

File Path Change Summary
.github/workflows/perl-build-docker.yml Deleted workflow for building Docker images for the Perl application.
.github/workflows/perl-code-tidy.yml Deleted workflow for performing code quality checks on Perl files.
.github/workflows/perl-package-build.yml Deleted workflow for building the Bystro Annotator Perl package.
.github/workflows/perl-test-install-apt.yml Deleted workflow for automating installation and verification using APT.
.github/workflows/perl-test-install-rpm.yml Deleted workflow for automating installation and verification using RPM.
BUILD.md Deleted documentation for configuring the Bystro tool for building databases.
Changes.md Deleted changelog documenting updates and changes across software versions.
Dockerfile.perl Deleted Dockerfile defining the environment for Perl development.
FIELDS.md Deleted documentation for annotation fields used in Bystro.
INSTALL.md Deleted installation instructions for the Bystro ancestry CLI and Annotator.
Makefile Removed install-go target and updated dependencies for installation and development.
README.md Modified for formatting and content organization, with some sections marked as "coming soon."
TUTORIAL.md Deleted comprehensive tutorial for the Bystro web application.
config/.gitignore Deleted ignore rule for beanstalk.yml.
config/hg19.yml Deleted configuration settings for the hg19 genome assembly.
config/hg38.yml Deleted configuration settings for the hg38 genome assembly.
dev-startup.yml Deleted configuration for Bystro development environment applications.
go/cmd/dosage/main.go Deleted command-line application for processing ARROW data files.
go/decompress/decompress.go Deleted functionality for reading and decompressing data from BGZF and Gzip formats.
go/decompress/decompress_test.go Deleted unit tests for decompression functionality.
go/go.mod Deleted module definition and dependency management for Go.
go/test/opensearch/testdata/input.txt Deleted test data formatted for specific input processing.
install-apt.sh Deleted installation script for various software components.
install-rpm.sh Deleted installation script for RPM dependencies.
install/detect-shell-profile.sh Deleted script for detecting and managing shell profile files.
install/export-bystro-libs.sh Deleted script for exporting Bystro libraries to the shell profile.
install/install-apt-deps.sh Deleted script for automating installation of APT dependencies.
install/install-go.sh Deleted script for automating the installation of the Go programming language.
install/install-htslib.sh Deleted script for installing libdeflate and HTSlib libraries.
install/install-liftover-linux.sh Deleted script for installing the liftOver tool.
install/install-lmdb-linux.sh Deleted script for installing the LMDB library.
install/install-mac-deps.sh Deleted script for installing Homebrew and MacOS dependencies.
install/install-perl-libs.sh Deleted script for installing various Perl libraries.
install/install-perlbrew-linux.sh Deleted script for installing Perl using perlbrew.
install/install-rpm-deps.sh Deleted script for installing RPM dependencies for MariaDB and development tools.
install/utils.sh Deleted utility script for appending lines to profile files.
perl/.gitignore Deleted ignore rules for the Perl project.
perl/.perlcriticrc Deleted configuration for Perl::Critic static analysis tool.
perl/.perltidyrc Deleted configuration for Perl Tidy code formatting tool.
perl/.tidyallrc Deleted configuration for Code::TidyAll coding standards enforcement.
perl/INSTALL.md Deleted installation and configuration instructions for the Bystro Annotator package.
perl/README.md Deleted comprehensive documentation for the Bystro High Dimensional Genomic Annotator.
perl/bin/bystro-annotate.pl Deleted script for annotating input files using the Bystro database.
perl/bin/bystro-build.pl Deleted script for building binary genome assemblies.
perl/bin/bystro-utils.pl Deleted script for executing utility functions based on configurations.
perl/bin/read_db_util.pl Deleted script for reading genomic data based on specified parameters.
perl/cpanfile Deleted file listing prerequisite Perl modules.
perl/dist.ini Deleted configuration settings for the Bystro Perl distribution.
perl/issues/subtxn_bug.pl Deleted script for managing a database using LMDB.
perl/lib/Interface.pm Deleted package for command-line interaction for data processing.
perl/lib/Seq.pm Deleted package responsible for annotating SNP files.
perl/lib/Seq/Base.pm Deleted base class for configuring logging and database settings.
perl/lib/Seq/Build.pm Deleted package for managing the construction of genome assembly files.
perl/lib/Seq/DBManager.pm Deleted package for managing database connections using LMDB.
perl/lib/Seq/Definition.pm Deleted package for managing attributes related to sequence processing.
perl/lib/Seq/Headers.pm Deleted module for managing header features in sequence data.
perl/lib/Seq/InputFile.pm Deleted module for validating input files related to SNP data.
perl/lib/Seq/Output.pm Deleted package for generating output strings from genomic data.
perl/lib/Seq/Output/Delimiters.pm Deleted package for managing delimiters used in output formatting.
perl/lib/Seq/Output/Fields.pm Deleted package for managing output fields in genomic data.
perl/lib/Seq/Role/ConfigFromFile.pm Deleted role for configuring classes using a YAML file.
perl/lib/Seq/Role/IO.pm Deleted role for handling file operations, particularly for compressed files.
perl/lib/Seq/Role/Message.pm Deleted role for logging and messaging functionalities.
perl/lib/Seq/Role/Validator.pm Deleted role for validating input files.
perl/lib/Seq/Statistics.pm Deleted package for managing statistical data related to genomic sequences.
perl/lib/Seq/Tracks.pm Deleted base class for managing track classes within genomic data processing.
perl/lib/Seq/Tracks/Base.pm Deleted base class for track-related functionalities.
perl/lib/Seq/Tracks/Base/MapFieldNames.pm Deleted package for managing feature name mappings.
perl/lib/Seq/Tracks/Base/MapTrackNames.pm Deleted package for managing track names and their identifiers.
perl/lib/Seq/Tracks/Base/Types.pm Deleted package for managing track types and conversions.
perl/lib/Seq/Tracks/Build.pm Deleted base class for building track objects.
perl/lib/Seq/Tracks/Build/CompletionMeta.pm Deleted package for tracking completion status of track builds.
perl/lib/Seq/Tracks/Build/LocalFilesPaths.pm Deleted package for constructing absolute paths for local files.
perl/lib/Seq/Tracks/Cadd.pm Deleted package for handling CADD data in genomic contexts.
perl/lib/Seq/Tracks/Cadd/Build.pm Deleted package for integrating CADD data into a main database.
perl/lib/Seq/Tracks/Cadd/Order.pm Deleted package for managing nucleotide ordering.
perl/lib/Seq/Tracks/Gene.pm Deleted package for managing gene-related data.
perl/lib/Seq/Tracks/Gene/Build.pm Deleted package for building gene tracks from reference data.

Possibly related PRs

  • reduce perl docker image size #579: The changes in this PR involve modifications to the Dockerfile.perl, which is directly related to the deleted .github/workflows/perl-build-docker.yml file in the main PR, as both pertain to the Docker image for the Perl application.
  • created doesn't act in the same way as expected, doesn't work on draft releases #592: This PR modifies the workflow configuration in .github/workflows/perl-build-docker.yml, which is directly related to the main PR that deleted this file, as both involve the workflow for building the Docker image.
  • Feature/remove unused go modules #595: The removal of unused Go modules in this PR may not directly relate to the main PR, but it involves changes to the Dockerfile and overall project structure, which could indirectly affect the build process described in the main PR.

Suggested reviewers

  • cristinaetrv

🐇 In the meadow, where changes abound,
Files have vanished, no longer found.
Workflows and scripts, all gone with a hop,
Bystro's journey takes a new stop.
With less in the basket, we tidy the way,
For brighter tomorrows, come what may! 🌼

Warning

Rate limit exceeded

@akotlar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 82aa318 and 7fcd607.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@cristinaetrv cristinaetrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@akotlar akotlar merged commit 7df7dd8 into bystrogenomics:master Nov 19, 2024
10 checks passed
@akotlar akotlar deleted the feature/cleanup branch November 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants