-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve globs using pathlib.glob() #37
resolve globs using pathlib.glob() #37
Conversation
I'd be very grateful if @byrnereese would consider sharing a short feedback on this. |
@AdrianDsg Thank you for the contribution. Do me one small favor - add something in the README.md about support for globs! |
It also appears the unit tests are failing. I am not sure if this change caused this error, but could you take a look? I think we just need to update the HASH value in the assertion: Update: Update: |
@byrnereese you were mostly right about the reason for the failing tests. The file hashes needed to be replaced but I also had to fix a bug that I previously introduced when using pathlib to resolve globs. |
Released as 0.8.0 |
fix #35
I just managed to integrate support for globs as mentioned in #35.
There might be more efficient ways to integrate this feature. Please feel free to share your feeback below.