Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle balances when using Bank Sync #108

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

bvanelli
Copy link
Owner

Allows the accounts to be reconciled when doing the first bank sync. This happens when the expected balance of the account does not match the final balance of the imported transactions, because old transactions are not imported.

This should only affect the first import using the bank sync, or if all transactions are deleted and a new bank sync is done.

Either way, it manages to reproduce 1:1 what we find on the simpleFin demo dataset, when importing from Actual or actualpy.

Closes #29

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (d2f2878) to head (19d9662).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   97.89%   97.90%   +0.01%     
==========================================
  Files          16       16              
  Lines        2283     2295      +12     
==========================================
+ Hits         2235     2247      +12     
  Misses         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit b3df262 into main Jan 26, 2025
9 checks passed
@bvanelli bvanelli deleted the 29-handle-balances-for-bank-sync branch January 26, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle starting balances for bank sync
1 participant