Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tile entity replacement configurable #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wmrojer
Copy link

@wmrojer wmrojer commented Jun 5, 2016

Made it possible to disable the WorldEventTick that replaces tiles
entites with upgraded versions to make Et Futurum play nice with
Mystcraft.

Made it possible to disable the WorldEventTick that replaces tiles
entites with upgraded versions to make Et Futurum play nice with
Mystcraft.
disabled world tick handler, since there was no way of getting then when
disabling the world tick handler.
@cosmicdan
Copy link

cosmicdan commented Mar 28, 2017

Looks good, thanks for this. Just found our server was using a huge amount of CPU and ~85% of it was from this tick method. Outrageous that it's reading the whole TE list every tick!

Found that you already made a build, awesome :)

@EzerArch
Copy link
Contributor

EzerArch commented Mar 28, 2017

Found that you already made a build, awesome :)

I'm interested in the build. The problem is, @ganymedes01 has been inactive for almost a year.

@cosmicdan
Copy link

cosmicdan commented Mar 29, 2017 via email

@EzerArch
Copy link
Contributor

Found it. Thanks. :)

@gatoborrachon
Copy link

Just found our server was using a huge amount of CPU and ~85% of it was from this tick method.

@cosmicdan sorry for necro this old pull request, but i had the doubt: the issue fixed on this Pull Request should not affect anyone that is not using Mystcraft or should i use it? (the release on wmrojer's fork)

@cosmicdan
Copy link

Just found our server was using a huge amount of CPU and ~85% of it was from this tick method.

@cosmicdan sorry for necro this old pull request, but i had the doubt: the issue fixed on this Pull Request should not affect anyone that is not using Mystcraft or should i use it? (the release on wmrojer's fork)

Whew it's been a while haha but I think Mystcraft was one specific combination where this caused an issue, because Mystcraft dimensions do something with TE's and it causes a bad interaction with Et Futurism.

Basically I found high CPU usage with both the mods, I used Java profiler and found this to be the cause; its not so much a fix but a work around.

@gatoborrachon
Copy link

oh ok, many thanks for the aclaration, it's just that i wanted to try the old 1.7 experience (which sadly i never tried before with a well-played survival game, i jumped directly from 1.6 to 1.10)

@Roadhog360
Copy link

Sorry to re-necro, but if you all are interested in a consistently updated version of this mod, check out my own fork. It also includes huge optimizations for this very thing and multiple config options for it. https://www.curseforge.com/minecraft/mc-mods/et-futurum-requiem

@gatoborrachon
Copy link

oh yeah, i started to use Et Futurum Requiem since i found it (some months after my comment on this issue), thanks anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants