Upgrade libs #297
Open
Upgrade libs #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from origin
blazsolar
requested changes
Nov 10, 2019
| import okhttp3.Interceptor; | ||
|
|
||
| @Module | ||
| public interface DataBindModule { | ||
|
|
||
| @Multibinds @ProviderScope Set<Interceptor> provideIntercptors(); | ||
| @Multibinds | ||
| Set<Interceptor> provideIntercptors(); |
There was a problem hiding this comment.
@PeroviderScope should stay in as it is important for third parties implementing ther own providers.
There was a problem hiding this comment.
I removed as I updated Dagger and it does not allow Scopes on Multibinding anymore
| @@ -39,12 +39,12 @@ | |||
| ) | |||
| public class ProviderModule { | |||
|
|
|||
| @Provides @ProviderScope @IntoSet ProviderWrapper provideVodoWrapper(final VodoProvider vodoProvider, | |||
| @Provides @IntoSet ProviderWrapper provideVodoWrapper(final VodoProvider vodoProvider, | |||
There was a problem hiding this comment.
@ProviderScope should stay in
| @@ -15,7 +15,7 @@ org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryErro | |||
| # When configured, Gradle will run in incubating parallel mode. | |||
| # This option should only be used with decoupled projects. More details, visit | |||
| # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | |||
| # org.gradle.parallel=true | |||
| org.gradle.parallel=true | |||
There was a problem hiding this comment.
does it actually do it? would you mind if I add a check to disable on CI? this helps speed when building locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.