stop using deprecated "keyCode", trigger hotkeys on keydown #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves us over to "key" rather than "keyCode". The latter is deprecated and slated for removal from web browsers...some time. This change does remove the "alt" option and instead requires "ctrl". Presumably no one will care. That was needed because key doesn't work as simply as keyCode when alt is held down (you get a "Dead" back instead). I doubt anyone will notice this, and I want to enhance hotkeys after this anyway (and document them in the frontend). Finally, this switches to keydown rather than keyup. The former is more natural. https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
srabraham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us over to "key" rather than "keyCode". The latter is deprecated and slated for removal from web browsers...some time.
This change does remove the "alt" option and instead requires "ctrl". Presumably no one will care. That was needed because key doesn't work as simply as keyCode when alt is held down (you get a "Dead" back instead). I doubt anyone will notice this, and I want to enhance hotkeys after this anyway (and document them in the frontend).
Finally, this switches to keydown rather than keyup. The former is more natural.
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode