don't send Set-Cookie back from eventsource calls #1456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the below issue, in a minimally hacky way.
The eventsource call doesn't require authentication, and
when a client does automatic connection retries on this
endpoint, it'll sometimes get back a Set-Cookie value
for a brand new, unauthenticated Twisted session. That
cookie value can stomp over a valid, authenticated session
cookie that the client may already have. The result is that
a user can effectively be logged out after a session lasting
less than a minute. That's not desirable.
#1363