migrate to Bootstrap 5, implement light/dark mode #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srabraham
force-pushed
the
2024-12-10-bootstrap5
branch
from
f655834 to
1927a03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
- Coverage 69.73% 69.71% -0.03%
==========================================
Files 181 181
Lines 8987 8987
Branches 1493 1493
==========================================
- Hits 6267 6265 -2
- Misses 2615 2616 +1
- Partials 105 106 +1 ☔ View full report in Codecov by Sentry. |
srabraham
force-pushed
the
2024-12-10-bootstrap5
branch
from
1927a03 to
ad0594f
Compare
The main reason to upgrade was to allow dark mode, which is something various nighttime Operators have been requesting for a while. This upgrade forced various other smaller changes too. The pages all look a bit different, but hopefully mostly for the better. I had to upgrade DataTables to get to a Bootstrap 5-compatible version. One other tweak in this PR is that the instructions on the Field Report page are turned into an accordion (a Bootstrap 5 thing), so that they can be hidden by default.
srabraham
force-pushed
the
2024-12-10-bootstrap5
branch
from
ad0594f to
f83ccd1
Compare
Closed
This was referenced Dec 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to upgrade was to allow dark mode, which is something
various nighttime Operators have been requesting for a while. This
upgrade forced various other smaller changes too. The pages all look
a bit different, but hopefully mostly for the better.
I had to upgrade DataTables to get to a Bootstrap 5-compatible version.
One other tweak in this PR is that the instructions on the Field Report
page are turned into an accordion (a Bootstrap 5 thing), so that they
can be hidden by default.