Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few improvements #4

Closed
wants to merge 5 commits into from
Closed

A few improvements #4

wants to merge 5 commits into from

Conversation

lekoala
Copy link

@lekoala lekoala commented Jun 27, 2014

  • Compatibility with CodeEditor module to make editing json nicer
  • Moved grid configuration to Settings
  • Added a description below the grid config to explain how to use it
  • Format json to make it look nice

@jedateach
Copy link
Member

Thanks @lekoala! Taking a look now. :)

@jedateach
Copy link
Member

@lekoala Thanks for submitting this pull request, however it was never my intention to rely on editing json by hand. I want to introduce an editor, as discussed in #3
Therefore unfortunately I won't be merging this pull request.

@jedateach jedateach closed this Jul 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lekoala @jedateach