Update to make it build/run with new functions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scarcely tested on Darwin (MacOS Ventura)
R0nni333
approved these changes
Jan 24, 2024
R0nni333
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scarcely tested on Darwin (MacOS Ventura).
Problem: with the current version provided by bunq, 'gradle build' will fail with multiple hard failures due to using deprecated/removed features. (As of version 8.0). Also maven has been renamed and relocated.
This quick fix makes "gradle build" complete successfully and creates the .jar files so that you can actually use Tinker again. :) (However only for PRODUCTION; because for tinkering/sandbox: just like the other SDK's (Python & PHP), it will fail to run claiming the endpoint is outdated. Sandbox will actually load fine after these changes, but it will error out with the "Your application version does not support this endpoint, please update your app" failure. )
Tested my changes in PRODUCTION-mode with the "UserOverview" feature. Also tested modifying "src/main/java/com/bunq/tinker/UserOverview.java", then run "gradle build" again to make the JAR reflect the changes and test "UserOverview --production" again afterwards. This is successful and dumps what I wanted it to dump in the quantity I wanted it to dump it. (Warning: trying to request more accounts or cards than you actually have will make it error out.)
The "gradle install" step still fails with these changes, but considering tinker actually works again now for PRODUCTION and allows to rebuild ("gradle build") (including after making changes to the configuration files): this is at least an improvement to the current state of affairs in the main tinker repository. :) It isn't perfection, but it at least makes it usable again.