Merge pull request #8 from BantiG/novo-7-upgrade-new

Novo 7 upgrade
bullhorn · Jul 28, 2023 · 5c9493e · 5c9493e
2 parents 9160f21 + db43fa4
commit 5c9493e
Show file tree

Hide file tree

Showing 23 changed files with 9,841 additions and 16,746 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,84 @@
+{
+  "root": true,
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts"
+      ],
+      "parserOptions": {
+        "project": [
+          "tsconfig.json",
+          "e2e/tsconfig.json"
+        ],
+        "createDefaultProgram": true
+      },
+      "extends": [
+        "plugin:@angular-eslint/ng-cli-compat",
+        "plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
+      "rules": {
+        "@angular-eslint/component-selector": [
+          "warn",
+          {
+            "type": "element",
+            "prefix": "platform",
+            "style": "kebab-case"
+          }
+        ],
+        "@angular-eslint/directive-selector": [
+          "warn",
+          {
+            "type": "attribute",
+            "prefix": "platform",
+            "style": "camelCase"
+          }
+        ],
+        "@typescript-eslint/naming-convention": [
+          "warn",
+          {
+            "selector": "default",
+            "format": ["camelCase"]
+          },
+          {
+            "selector": "variable",
+            "format": ["camelCase", "UPPER_CASE"]
+          },
+          {
+            "selector": "typeLike",
+            "format": ["PascalCase"]
+          }
+        ],
+        "@typescript-eslint/consistent-type-definitions": "error",
+        "@typescript-eslint/dot-notation": "off",
+        "@typescript-eslint/explicit-member-accessibility": [
+          "off",
+          {
+            "accessibility": "explicit"
+          }
+        ],
+        "@typescript-eslint/no-use-before-define": "error",
+        "brace-style": [
+          "error",
+          "1tbs"
+        ],
+        "id-blacklist": "off",
+        "id-match": "off",
+        "no-trailing-spaces": "off",
+        "no-underscore-dangle": "off"
+      }
+    },
+    {
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended"
+      ],
+      "rules": {}
+    }
+  ]
+}
diff --git a/.gitignore b/.gitignore
@@ -26,6 +26,7 @@
 !.vscode/extensions.json
 
 # misc
+/.angular/cache
 /.sass-cache
 /connect.lock
 /coverage

diff --git a/.prettierrc b/.prettierrc
@@ -1,10 +1,19 @@
 {
-  "useTabs": false,
-  "tabWidth": 2,
   "singleQuote": true,
-  "trailingComma": "all",
+  "useTabs": false,
   "semi": true,
+  "bracketSpacing": true,
   "printWidth": 140,
+  "tabWidth": 2,
+  "trailingComma": "all",
   "arrowParens": "always",
-  "jsxBracketSameLine": false
-}
+  "endOfLine": "lf",
+  "overrides": [
+    {
+      "files": "*.scss",
+      "options": {
+        "singleQuote": false
+      }
+    }
+  ]
+}
diff --git a/README.md b/README.md
@@ -7,6 +7,25 @@
 
 ## Getting Started
 
+##### Prerequisites: Node v14.15.x or later
+
 * Clone This
 * `npm install` or `yarn install`
 * `npm start`
+
+
+## Upgrade Process
+
+In general, the upgrade process will vary slightly everytime. However, websites such as https://update.angular.io help walk you through the process for each version of Angular. For a concrete example, the entire process of cloning + upgrading from Angular 10 to 13 is detailed below:
+
+1. `git clone x`
+2. `npm install`
+3. Run `ng update @angular/core@11 @angular/cli@11 --allow-dirty` to take Angular from v10 to v11
+4. Run `ng update @angular/core@12 @angular/cli@12 --allow-dirty` to take Angular from v11 to v12
+5. Manually update `@angular/cdk` to the Angular 12 version in package.json to fix dependency error
+6. `npm install` to install updated `@angular/cdk` and its dependencies
+7. `ng update @angular/core@13 @angular/cli@13 --allow-dirty` to take Angular from v12 to v13
+8. Update other NPM packages manually in package.json (this was primarily done by looking at packages on https://npmjs.org / text output from `npm install`)
+9. `npm install`
+10. `ng update novo-elements --migrate-only --from=0.0.0 --to=7.0.0 --force --allow-dirty` to update Novo Elements to v7
+11. Manually resolve compile errors (mainly just paths) within Angular app
diff --git a/angular.json b/angular.json
@@ -11,6 +11,14 @@
         "build": {
           "builder": "@angular-devkit/build-angular:browser",
           "options": {
+            "allowedCommonJsDependencies": [
+              "@bullhorn/taurus",
+              "@bullhorn/dragula",
+              "brace/mode/javascript",
+              "angular2-text-mask",
+              "sha.js",
+              "date-fns"
+            ],
             "outputPath": "dist",
             "index": "src/index.html",
             "main": "src/main.ts",
@@ -32,14 +40,20 @@
             ],
             "scripts": [
               "node_modules/post-robot/dist/post-robot.min.js"
-            ]
+            ],
+            "aot": false,
+            "vendorChunk": true,
+            "extractLicenses": false,
+            "buildOptimizer": false,
+            "sourceMap": true,
+            "optimization": false,
+            "namedChunks": true
           },
           "configurations": {
             "prod": {
               "optimization": true,
               "outputHashing": "all",
               "sourceMap": false,
-              "extractCss": true,
               "namedChunks": false,
               "aot": true,
               "extractLicenses": true,
@@ -53,6 +67,8 @@
               ]
             },
             "staging": {
+              "optimization": false,
+              "sourceMap": true,
               "fileReplacements": [
                 {
                   "replace": "src/environments/environment.ts",
@@ -61,14 +77,17 @@
               ]
             },
             "local": {
+              "optimization": false,
+              "sourceMap": true,
               "fileReplacements": [
                 {
                   "replace": "src/environments/environment.ts",
                   "with": "src/environments/environment.local.ts"
                 }
               ]
             }
-          }
+          },
+          "defaultConfiguration": ""
         },
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
@@ -114,13 +133,12 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "src/tsconfig.app.json",
-              "src/tsconfig.spec.json"
-            ],
-            "exclude": []
+            "lintFilePatterns": [
+              "src/**/*.ts",
+              "src/**/*.html"
+            ]
           }
         }
       }
@@ -136,15 +154,6 @@
             "protractorConfig": "./protractor.conf.js",
             "devServerTarget": "platform-extension-starter:serve"
           }
-        },
-        "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
-          "options": {
-            "tsConfig": [
-              "e2e/tsconfig.e2e.json"
-            ],
-            "exclude": []
-          }
         }
       }
     }
@@ -153,10 +162,13 @@
   "schematics": {
     "@schematics/angular:component": {
       "prefix": "platform",
-      "styleext": "scss"
+      "style": "scss"
     },
     "@schematics/angular:directive": {
       "prefix": "platform"
     }
+  },
+  "cli": {
+    "defaultCollection": "@angular-eslint/schematics"
   }
 }