adding laggin span line to ta.momentum.IchimokuIndicator #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding Tenkan-sen and Kijun-sen methods for IchimokuIndicator
fixing bug: min_periods when fillna=False
fixed column names on Indicator Donchian Channel
Update wrapper.py
Fix money flow index col name
Improving the documentation
Added iloc after dropna in ADX indicator
Refactor Series.fillna in utils.py to address FutureWarning
Apply the black linter
Added 0-in-denominator checks in trend.ADXIndicator
replaced fill_value to 1 instead of close.mean
something like this
Fixing linter details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lagging span line will be useful if added to library. thanks
Lagging span is described here:
https://www.investopedia.com/terms/c/chikouspan.asp#:~:text=The%20Chikou%20span%20is%20a,closing%20price%20of%20an%20asset.&text=Many%20traders%20watch%20for%20the,signal%20a%20potential%20trend%20change.