Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to cowboy 2.8.0 #1

Open
wants to merge 12 commits into
base: palaver
Choose a base branch
from
Open

upgrade to cowboy 2.8.0 #1

wants to merge 12 commits into from

Conversation

aferryc
Copy link

@aferryc aferryc commented Feb 5, 2021

No description provided.

Copy link

@miduddin miduddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

di README.md bagian testing ada:

To run Cowboy test_server:

    cd sockjs-erlang
    ./rebar get-deps
    ./rebar compile
    ./examples/cowboy_test_server.erl

itu skrg ga jalan. bisa tolong dibenerin jg?

edit: dan kalau bisa pastikan lolos test sesuai yg dijelaskan di README.md jg (yg pake sockjs-protocol/sockjs-client).

@aferryc
Copy link
Author

aferryc commented Feb 17, 2021

di README.md bagian testing ada:

To run Cowboy test_server:

    cd sockjs-erlang
    ./rebar get-deps
    ./rebar compile
    ./examples/cowboy_test_server.erl

itu skrg ga jalan. bisa tolong dibenerin jg?

edit: dan kalau bisa pastikan lolos test sesuai yg dijelaskan di README.md jg (yg pake sockjs-protocol/sockjs-client).

paling cuma bisa diusahain lolos test yg websocket sama bbrp endpoint yg dibuka aja

di commit c4740f6

endpoint yang lain di disable (mungkin regarding security)

@miduddin
Copy link

ya, minimal fungsi yg kita pakai bisa dites.

@SimonWoolf
Copy link

👋 Heya, in case it helps I did some bugfixes for this, feel free to cherry-pick any of them 🙂
SimonWoolf@090e935
SimonWoolf@718b2df
SimonWoolf@a81399f
SimonWoolf@6b5385f
SimonWoolf@f39d96d
SimonWoolf@a46ddd8
To get the hook-tcp-close stuff working I needed to fork cowboy to expose the socket:
SimonWoolf@5bee1f9
SimonWoolf/cowboy@21b821a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants