Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional example of server auth #753

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

johnman
Copy link
Member

@johnman johnman commented Nov 6, 2024

Added a second manifest with an example where the provider is not visible by default and preload scripts are used to determine if the right url is loaded in the hidden window.

Also added an additional scenario where the server auth may use redirects and a redirect may become stuck and the provider.html is never loaded.

Added a second manifest with an example where the provider is not visible by default and preload scripts are used to determine if the right url is loaded in the hidden window.

Also added an additional scenario where the server auth may use redirects and a redirect may become stuck and the provider.html is never loaded.
@johnman johnman requested a review from smocarski November 6, 2024 18:59
Copy link

@rdepena rdepena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@johnman johnman requested review from rdepena, joeransegnola and ameetj85 and removed request for rdepena November 6, 2024 20:14
@johnman johnman merged commit 1bad456 into main Nov 6, 2024
2 checks passed
@johnman johnman deleted the dev/john/alternate-server-auth-scenario branch November 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants