-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no such file or directory errors fix #58
Conversation
Hey @Manik2708 , thanks for contributing! Can you please follow this and make a dedicated commit for adding yourself to CONTRIBUTORS.md? |
Signed-off-by: Manik2708 <Manik2708> Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <Manik2708> Signed-off-by: Manik2708 <[email protected]>
@dr-housemd DCO is fixed, please run the workflow |
@dr-housemd @rakshitgondwal Please review this PR |
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
@Manik2708 thanks for the PR, this is a great contribution. Especially, impressed with the test coverage. |
Signed-off-by: Manik2708 <[email protected]>
@Manik2708 CI is failing. Can you-
|
I am little confused regarding the build in CI. It is using the build command of bsf itself to build the project, but the recent changes will throw the error if |
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
I finally got to know why this error was coming, |
Finally CI passed:) |
Fixes: #8
go.mod
and other languages entry file are not added to version control, error will be thrownThis PR also focuses on one of the problem which I faced during contribution. I was not able to use debugger to test my changes. Rebuilding again and again can be tedious, so I tried to write test for
git.go
. This test is not a Unit Test as those includes mocking. Mocking git is complex and may include DI, so I approached it by another way. This test create absf-temp
directory outside the project folder and delete it after the test is completed. I have to create it outside the project directory because the git tree of project should not be hampered. Now testing the git pkg is very simple. But this has some problems:bsf-temp
could contain personal data of developer and tests include deleting this folder, so it may lead developer loosing data. But this can be fixed by creating random name folders for testing or asking the name of temp folder from developer during setup.If my approach is right, then I can work on testing
build
andinit
command as these commands are very much prone to changes.And if there is some problem I can remove
git_test.go
from this PR