Merge pull request #94 from buildpulse/printenvvar

Print missing environment variables on error
buildpulse · Nov 6, 2023 · 1d8893d · 1d8893d
2 parents 7e01ff7 + 4340a77
commit 1d8893d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/internal/metadata/metadata_test.go b/internal/metadata/metadata_test.go
@@ -206,7 +206,7 @@ func TestNewMetadata(t *testing.T) {
 func TestNewMetadata_unsupportedProvider(t *testing.T) {
 	_, err := NewMetadata(&Version{}, map[string]string{}, []string{}, newCommitResolverStub(), time.Now, logger.New())
 	if assert.Error(t, err) {
-		assert.Contains(t, err.Error(), "missing required environment variables")
+		assert.Contains(t, err.Error(), "env: environment variable \"GIT_BRANCH\" should not be empty; environment variable \"GIT_COMMIT\" should not be empty; environment variable \"BUILD_URL\" should not be empty; environment variable \"ORGANIZATION_NAME\" should not be empty; environment variable \"REPOSITORY_NAME\" should not be empty")
 	}
 }
 

diff --git a/internal/metadata/providers.go b/internal/metadata/providers.go
@@ -1,7 +1,6 @@
 package metadata
 
 import (
-	"errors"
 	"fmt"
 	"net/url"
 	"os"
@@ -708,7 +707,7 @@ type customMetadata struct {
 
 func (w *customMetadata) Init(envs map[string]string, log logger.Logger) error {
 	if err := env.Parse(w, env.Options{Environment: envs}); err != nil {
-		return errors.New("missing required environment variables")
+		return err
 	}
 
 	log.Printf("Using $GIT_COMMIT environment variable as commit SHA: %s", w.GitCommit)