Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Run Image Metadata #313

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

joeybrown-sf
Copy link
Contributor

@joeybrown-sf joeybrown-sf commented Apr 11, 2024

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

Signed-off-by: Joey Brown <[email protected]>
- Rebase process may remain suboptimal for some platform providers.

2. Write all the metadata labels to `report.toml`.
- This could break platform operators that are using the `terminationMessagePath` [pattern](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#pod-v1-core). Because some of the metadata includes unbounded arrays, we could explode this report beyond the max size of 4096 bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomkennedy513 do you have any feedback here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I don't think we're close to hitting the limit yet (though it's been said before...)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC kpack doesn't blindly dump the report.toml directly, it parses out only the stuff it cares about and writes that to terminationMessagePath instead.

I don't think we've encountered any issues with length yet, but I image that's because we limit the unbounded array to just the id, version, and homepage metadata of buildpacks.

Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

…n-image-metadata.md

Updating for merge

Signed-off-by: Jesse Brown <[email protected]>

Signed-off-by: Jesse Brown <[email protected]>
@jabrown85 jabrown85 merged commit 34caba7 into buildpacks:main Jul 8, 2024
7 checks passed
@joeybrown-sf joeybrown-sf deleted the extend-report-toml branch July 8, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants