Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion of ephemeral builder #2260

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

natalieparellano
Copy link
Member

createEphemeralBuilder mutates the provided rawBuilderImage, so we must save the image name before this method is called.

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

`createEphemeralBuilder` mutates the provided `rawBuilderImage`, so we must save the image name
before this method is called.

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano linked an issue Sep 5, 2024 that may be closed by this pull request
@github-actions github-actions bot added this to the 0.36.0 milestone Sep 5, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (df70f4c) to head (97c9422).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
+ Coverage   70.02%   70.03%   +0.01%     
==========================================
  Files         254      254              
  Lines       18673    18674       +1     
==========================================
+ Hits        13074    13076       +2     
+ Misses       4731     4730       -1     
  Partials      868      868              
Flag Coverage Δ
os_linux 69.17% <100.00%> (-<0.01%) ⬇️
os_macos-arm64 65.35% <100.00%> (+0.02%) ⬆️
os_windows 69.55% <100.00%> (+0.01%) ⬆️
unit 70.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano marked this pull request as ready for review September 5, 2024 18:09
@natalieparellano
Copy link
Member Author

Confirmed manually that with this change we don't see a pack.local/builder/<uid> hanging around after the build

Copy link
Contributor

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalieparellano Thank you for looking into this - I've tested locally using the artifact attached to the GitHub Actions run and can confirm it resolves the issue (using the STR from #2255) :-)

@natalieparellano natalieparellano merged commit e545151 into main Sep 11, 2024
18 checks passed
@natalieparellano natalieparellano deleted the fix/delete-ephemeral-builder branch September 11, 2024 21:45
@edmorley
Copy link
Contributor

Would it be possible to release a new version of Pack CLI that includes this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral builder image not deleted at the end of the build
2 participants