-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply package config from meta-buildpack folder in pack build #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/enhancement
Issue that requests a new feature or improvement.
type/chore
Issue that requests non-user facing changes.
labels
Jul 18, 2023
Tests are failing due to moby/moby#45935 |
Signed-off-by: Colin Casey <[email protected]>
Generate a release for Ubuntu Lunar Lobster Signed-off-by: Aidan Delaney <[email protected]> Signed-off-by: Colin Casey <[email protected]>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.2+incompatible to 24.0.5+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.2...v24.0.5) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Colin Casey <[email protected]>
Signed-off-by: Colin Casey <[email protected]>
* main: build(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 build(deps): bump github.com/onsi/gomega from 1.27.8 to 1.27.10 build(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 build(deps): bump github.com/docker/cli build(deps): bump github.com/docker/docker Update the summary of `yank` Release to Ubuntu Lunar PPA build(deps): bump github.com/docker/docker build(deps): bump golang.org/x/oauth2 from 0.9.0 to 0.10.0 build(deps): bump github.com/opencontainers/image-spec build(deps): bump github.com/docker/cli # Conflicts: # go.mod
Signed-off-by: Colin Casey <[email protected]>
Signed-off-by: Colin Casey <[email protected]>
dlion
reviewed
Aug 2, 2023
dlion
reviewed
Aug 2, 2023
Thank you for this PR @colincasey it looks almost good to me, I left some comments 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @colincasey! This looks good to me. I liked the small readability suggestion from @dlion ❤️
- extracted the fetching of buildpacks from package.toml into its own function - added test to cover error scenario Signed-off-by: Colin Casey <[email protected]>
Signed-off-by: Colin Casey <[email protected]>
Signed-off-by: Colin Casey <[email protected]>
natalieparellano
approved these changes
Aug 4, 2023
jkutner
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When supplying a meta-buildpack folder as an argument to the build command (e.g.;
pack build --buildpack <path to meta-buildpack folder> ...
) thepackage.toml
configuration file within the directory is ignored. If the meta-buildpack references a buildpack that only exists locally, that buildpack will fail to resolve.This behavior differs from using a meta-buildpack with
pack buildpack package ...
and thenpack build --buildpack <CNB file or OCI image reference> ...
. The CNB file or OCI image reference created contains all the referenced buildpacks listed from thepackage.toml
within itself and those get extracted and included as extra buildpacks during the build process.This PR attempts to detect when a meta-buildpack folder is supplied during the build process and, if a
package.toml
file is found, it will extract any referenced buildpacks so that there is no difference in behavior when supplying a meta-buildpack as a folder, CNB file, or OCI image.Output
Before
After
Resolves #1320