Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles phase 1 (detect changes) #860

Merged
merged 61 commits into from
Jun 8, 2022
Merged

Dockerfiles phase 1 (detect changes) #860

merged 61 commits into from
Jun 8, 2022

Commits on Feb 22, 2022

  1. Acceptance tests pass with creator commented out 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5a4832b View commit details
    Browse the repository at this point in the history

  2. Fix creator 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    ed1b3a7 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for analyze inputs 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    fc4a7e3 View commit details
    Browse the repository at this point in the history

  4. Add scaffold for analyzer builder unit tests 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2b505c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Add many unit tests, still have some TODOs 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    6fef994 View commit details
    Browse the repository at this point in the history

  2. Address most TODOs 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    043974b View commit details
    Browse the repository at this point in the history

  3. Acceptance tests pass 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    02a5c74 View commit details
    Browse the repository at this point in the history

  4. A few more TODOs 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    785d81a View commit details
    Browse the repository at this point in the history

  5. Bring back go 1.16 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    e58d007 View commit details
    Browse the repository at this point in the history

  6. Add unit test 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    125f01f View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Fix acceptance tests 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    4b4e816 View commit details
    Browse the repository at this point in the history

  2. Fix units 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    8294ea5 View commit details
    Browse the repository at this point in the history

  3. Remove nolint 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    fd6beb3 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded things 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    8335a56 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Use operations pattern 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    9ee1dfd View commit details
    Browse the repository at this point in the history

  2. Refactor tests to take advantage of operations pattern 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    d21352f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Add missing tests 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    d81cb6c View commit details
    Browse the repository at this point in the history

  2. Fix lint 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    d815707 View commit details
    Browse the repository at this point in the history

  3. Analyzer factory assigns "nop" services by default 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    46a24ae View commit details
    Browse the repository at this point in the history

  4. Try to fix registry handler test 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    fe83502 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Move new package from cmd/lifecycle/platform to platform/inputs 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    f72848d View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Merge branch 'main' into cmd-package 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a457244 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Updates per PR review 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    c828d03 View commit details
    Browse the repository at this point in the history

  2. Test the platform instead of the exiter 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    e0e8d8a View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Combine cmd/lifecycle/platform and platform 

    With some small changes to avoid an import cycle, we can make a meaningful platform package

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    0af8ab2 View commit details
    Browse the repository at this point in the history

  2. Clean up constructors 

    Eventually only the platform package should switch on platform api

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    fcac2e3 View commit details
    Browse the repository at this point in the history

  3. Remove ForAnalyzer struct 

    Having the analyzer factory take a list of args will ensure we don't forget
to update the creator when things change.

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    59097ca View commit details
    Browse the repository at this point in the history

  4. Combine cmd/launcher/platform and platform 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    76811ce View commit details
    Browse the repository at this point in the history

  5. Remove comment 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    2d4a9bc View commit details
    Browse the repository at this point in the history

  6. Remove spec alias 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e06cb9c View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Move cache metadata back to platform 

    The lifecycle shouldn't have to depend on the cache package, just the interface

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c982fb1 View commit details
    Browse the repository at this point in the history

  2. Add comment and remove unused vars 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    4aa3115 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cmd-package 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2078007 View commit details
    Browse the repository at this point in the history

  4. Move buildpack store and make it hold extensions also 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f358c2d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. WIP: detector units pass 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    462bf4e View commit details
    Browse the repository at this point in the history

  2. Rename GroupBuildpack to GroupElement 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    476d407 View commit details
    Browse the repository at this point in the history

  3. Move Buildpack interface to buildpack package and rename BuildModule 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    ecec7a8 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 3, 2022
    Configuration menu
    Copy the full SHA
    42a9351 View commit details
    Browse the repository at this point in the history

  2. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c693e7d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 6, 2022
    Configuration menu
    Copy the full SHA
    61abad0 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 7, 2022
    Configuration menu
    Copy the full SHA
    d6a0204 View commit details
    Browse the repository at this point in the history

  2. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 7, 2022
    Configuration menu
    Copy the full SHA
    81408eb View commit details
    Browse the repository at this point in the history

  3. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 7, 2022
    Configuration menu
    Copy the full SHA
    788999e View commit details
    Browse the repository at this point in the history

  4. WIP 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 7, 2022
    Configuration menu
    Copy the full SHA
    e93fc73 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into dockerfiles-phase-1-detect

    @natalieparellano
    natalieparellano committed May 7, 2022
    Configuration menu
    Copy the full SHA
    35b6f7b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Verify buildpack apis when reading order 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 24, 2022
    Configuration menu
    Copy the full SHA
    4189ea3 View commit details
    Browse the repository at this point in the history

  2. Update comment 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 24, 2022
    Configuration menu
    Copy the full SHA
    8155aae View commit details
    Browse the repository at this point in the history

  3. Remove comment 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 24, 2022
    Configuration menu
    Copy the full SHA
    f71def2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Decouple config handler and api verifier 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 26, 2022
    Configuration menu
    Copy the full SHA
    ff567c8 View commit details
    Browse the repository at this point in the history

  2. Move var to file where it is used 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d070f0a View commit details
    Browse the repository at this point in the history

  3. Add tests 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed May 26, 2022
    Configuration menu
    Copy the full SHA
    38287b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Add TODO 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    0b6cf13 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Merge branch 'main' into dockerfiles-phase-1-detect

    @natalieparellano
    natalieparellano committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    0a54192 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Updates per PR review 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e92a8b7 View commit details
    Browse the repository at this point in the history

  2. Don't fail detect if /bin/detect and plan.toml are both missing 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c518697 View commit details
    Browse the repository at this point in the history

  3. Fix cherry pick 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    46375d0 View commit details
    Browse the repository at this point in the history

  4. APIVerifier takes a kind 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3eb9961 View commit details
    Browse the repository at this point in the history

  5. DirStore takes a kind 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3a0218d View commit details
    Browse the repository at this point in the history

  6. detect_test.go uses kind 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    7130656 View commit details
    Browse the repository at this point in the history

  7. Ensure that optional information is preserved 

    - ReadOrder returns an order for extensions that has "extension = true" filled in
- Remove some duplication in the detector

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    0a358b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Remove ToGroupElement() weirdness and fix comparison 

    Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    bc0a646 View commit details
    Browse the repository at this point in the history