Updated icons, theme and improved icon device support #3030
Conversation
CoreyGinnivan
commented
Jan 14, 2025
•
CoreyGinnivan
commented
- Updated Favicon as part of the wider Buildkite favicon upgrade
- Moved to using SVG favicon by default with PNG fallback
- Removed older methods (masked/pinned icons, .ico)
- Added better theming for Android/Safari
- Added web manifest
There was a problem hiding this comment.
Changes look good and can see the updated favicon on the deploy preview.
Couple of comments, I reckon we should look at making the docs apple touch icon distinct just in the edgy-est of edge cases, if someone adds both bk/bk and bk/docs to their dock/home screen, they look distinct. This could still be done separate to deploying favicons though.
There was a problem hiding this comment.
GitHub’s diff view is sad about this file for some reason (maybe an issue on my end?), but viewing the file directly seems ok.
| "short_name": "Buildkite Docs", | ||
| "start_url": "/docs", | ||
| "display": "standalone", | ||
| "description": "Automate your team’s software development processes, from testing through to delivery, no matter the language, environment or toolchain.", |
There was a problem hiding this comment.
Wonder if there’s any value in distinct manifest descriptions between site/docs/product dashboard?
(Not a high priority, didn’t even have the manifest before.)
There was a problem hiding this comment.
Honestly got no idea haha, I just based it on our url setups but nfi what it actually does and what it affects 😅
There was a problem hiding this comment.
If someone added docs and bk/bk to their dock, would the dock icons would be identical?
Maybe a macOS dock icon is an opportunity for a more expressive, Gavin Nelson style app icon which includes some sort of docs illo affordance (inb4 beautifully 3d rendered curling document page illo)
There was a problem hiding this comment.
Yeah I reckon this is a solid call - as you suggested each site/app having it's own unique flavour would be awesome
