Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed note on concurrency group/matrix usage #2581

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

james2791
Copy link
Contributor

@james2791 james2791 commented Dec 4, 2023

The note below in the build_matrix page indicates that you are able to use matrix setup dimension values inside concurrency groups (i.e name): like the below

steps:
- label: "A Matrix Build"
  command: "echo {{matrix.os}} {{matrix.arch}} {{matrix.test}}"
  concurrency: 1
  concurrency_group: "group-{{matrix.arch}}"
  matrix:
    setup:
      arch:
        - "amd64"
      os:
        - "macos"
      test:
        - "alpha"

That interpolation for the CG's name at the moment isn't supported - and will cause confusion for those hoping the dynamic naming/support can work in current form (either hard coded names/plugins are the way around this)

@github-actions github-actions bot added the pipelines Pull requests that update content related to Pipelines label Dec 4, 2023
Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, then this looks all good :)

pages/pipelines/build_matrix.md Outdated Show resolved Hide resolved
@mbelton-buildkite mbelton-buildkite merged commit 857014f into main Jan 9, 2024
2 checks passed
@mbelton-buildkite mbelton-buildkite deleted the concurrency-group-matrix branch January 9, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines Pull requests that update content related to Pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants