-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST API docs for creating annotations #2546
Add REST API docs for creating annotations #2546
Conversation
- parallel_group_index - parallel_group_total - matrix - cluster_id - cluster_url - cluster_queue_id - cluster_queue_url
Preview URL: https://2546--bk-docs-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, but looking good in general 😊
"retried_in_job_id": null, | ||
"retries_count": null, | ||
"retry_type": null, | ||
"parallel_group_index": null, | ||
"parallel_group_total": null, | ||
"matrix": null, | ||
"cluster_id": null, | ||
"cluster_url": null, | ||
"cluster_queue_id": null, | ||
"cluster_queue_url": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the any meaningful values we could use here instead of null
? We're not the best at including example values for fields so these responses do a lot of heavy lifting for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could definitely look to expand on some of these in the future, but in this case I want to get this (long overdue!) API doc update out, so I'm merging this now (after applying all of your other feedback, thank you!)
Document a new
POST /v2/organizations/{org.slug}/pipelines/{pipeline.slug}/builds/{build.number}/annotations
endpoint for creating build annotations.While here:
parallel_group_index
,parallel_group_total
,matrix
,cluster_id
,cluster_url
,cluster_queue_id
,cluster_queue_url
201 Created
status cods