Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduler): pod-spec-patch was not working on default init containers #484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scheduler): pod-spec-patch was not working on default init containers #484

wants to merge 1 commit into from
+25 −11

Conversation

defgenx
Copy link

@defgenx defgenx commented Jan 24, 2025 •
edited
Loading

Description

This PR resolves an issue where the PodSpecPatch for default initContainers was not functioning correctly in the scheduler.

Changes

  • Fixed duplication of init containers in podSpecPatch when the init-container exists.
  • Update the documentation for patching resources.
  • Ensure the documentation of pod-spec-patch is aligned with what the code is doing.

@defgenx defgenx force-pushed the fix-pod-spec-patch-init-container branch 2 times, most recently from 30f1247 to a9f5427 Compare January 24, 2025 16:51
@defgenx defgenx force-pushed the fix-pod-spec-patch-init-container branch from a9f5427 to 2d9b15c Compare January 24, 2025 16:53
@defgenx defgenx changed the title fix(scheduler): pod-spec-patch was not working on init containers fix(scheduler): pod-spec-patch was not working on default init containers Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@defgenx